Add a test case ensuring touch events are dispatched to views overflowing ScrollView content container#49967
Closed
j-piasecki wants to merge 2 commits into
Closed
Add a test case ensuring touch events are dispatched to views overflowing ScrollView content container#49967j-piasecki wants to merge 2 commits into
j-piasecki wants to merge 2 commits into
Conversation
…hey overflow content container (facebook#49855) Summary: Changelog: [IOS][FIXED] - Fixed touch events not being dispatched to ScrollView's children when they overflow the content container Closes facebook#47740. Changes the ScrollView's container view to be `RCTViewComponentView` instead of `UIView` and sets custom layout metrics to it in a way that it will propagate touch events to all children, even if they overflow its bounds. Reviewed By: sammy-SC Differential Revision: D70619894
…wing ScrollView content container Summary: Changelog: [Internal] Differential Revision: D71030561
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71030561 |
Contributor
|
This pull request has been merged in 39f051a. |
Collaborator
|
This pull request was successfully merged by @j-piasecki in 39f051a When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Internal]
Differential Revision: D71030561